feat(feign-10.8): toolkit-generated feign HTTP client instrumentation [DO NOT MERGE]#11709
Draft
jordan-wong wants to merge 1 commit into
Draft
feat(feign-10.8): toolkit-generated feign HTTP client instrumentation [DO NOT MERGE]#11709jordan-wong wants to merge 1 commit into
jordan-wong wants to merge 1 commit into
Conversation
Toolkit-generated greenfield instrumentation for Feign HTTP client v10.8+. Run details: - Branch (toolkit): eval/java @ 757979b9 - Branch (worktree): eval/feign-blind-attempt1-20260623 in /Users/jordan.wong/dd-trace-java-eval-feign - Workflow: new_integration, completed 2026-06-23 - Cost: $26.95, 78min, reviewer approved=True - Maven coordinates: io.github.openfeign:feign-core:10.8 Generated module: dd-java-agent/instrumentation/feign/feign-10.8-generated/ - FeignClientInstrumentation (sync Client.execute) - FeignAsyncClientInstrumentation (async AsyncClient.execute) - FeignClientDecorator (HttpClientDecorator) - RequestHeaderInjectAdapter (header injection for distributed tracing) - SpanFinishingCallback (async future completion) - Java tests (FeignClientTest, FeignAsyncClientTest) per R20 Supersedes #10855 (Feign 8.0, stale) and closed #10980 (Feign 10.8, never independently verified). ## Research integrity note `metadata/supported-configurations.json` (4 entries: DD_TRACE_FEIGN_10_8_ENABLED, DD_TRACE_FEIGN_ANALYTICS_ENABLED, DD_TRACE_FEIGN_ANALYTICS_SAMPLE_RATE, DD_TRACE_FEIGN_ENABLED) was **hand-added** by the human operator AFTER the toolkit run; the toolkit's R29 rule was added later in the same session (see commit 757979b9 on eval/java). This is documented in docs/eval-research/generated/feign-20260623/caveats.md. `settings.gradle.kts` line addition is a faithful replay of what the toolkit produced in the eval worktree. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toolkit-generated greenfield instrumentation for Feign HTTP client v10.8+. Supersedes #10855 (Feign 8.0, stale) and closed #10980 (Feign 10.8, never independently verified under current methodology).
Generated module
dd-java-agent/instrumentation/feign/feign-10.8-generated/FeignClientInstrumentation(syncClient.execute)FeignAsyncClientInstrumentation(asyncAsyncClient.execute)FeignClientDecoratorextendsHttpClientDecoratorRequestHeaderInjectAdapter(header injection for distributed tracing)SpanFinishingCallback(async future completion handler)Run details
eval/java@757979b9new_integration(default)io.github.openfeign:feign-core:10.8Research integrity disclosure
metadata/supported-configurations.json(4 entries:DD_TRACE_FEIGN_10_8_ENABLED,DD_TRACE_FEIGN_ANALYTICS_ENABLED,DD_TRACE_FEIGN_ANALYTICS_SAMPLE_RATE,DD_TRACE_FEIGN_ENABLED) was hand-added by the human operator AFTER the toolkit run. The toolkit's R29 rule that would produce these automatically was added later in the same session (commit757979b9oneval/java).settings.gradle.ktsline addition is a faithful replay of what the toolkit produced in the eval worktree.Full caveats: see
docs/eval-research/generated/feign-20260623/caveats.mdin the apm-instrumentation-toolkit repo (eval/java branch).Next steps
:check,:muzzle,:instrumentationLatestDepTest)RoutesInstrumentation— typo (please scrutinize sync vs async wrapping per R2, single-module rule per R3)🤖 Generated with Claude Code