Skip to content

Add agentless and standalone OpenFeature smoke tests - #12846

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bbujon/ffe-extras
Oct 29, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
masterfrom
bbujon/ffe-extras

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

What Does This Do

Extracts the shared OpenFeature smoke test scenarios into AbstractOpenFeatureSmokeTest and runs them in three setups: SDK only (standalone), SDK + agent in agentless mode, and SDK + agent with Remote Configuration. Updates ARCHITECTURE.md, and adds the dd-openfeature SDK README: setup, configuration, features by setup, migration from earlier versions and design notes for contributors.

Motivation

Covers each supported setup of the standalone SDK (APMLP-1512).

Stack

The full change is in #12709. It was split into this stack to ease the review.

  1. Resolve Feature Flags enablement from instrumenter config #12845
  2. Add dd-openfeature SDK flag configuration and evaluation core #12840
  3. Add dd-openfeature SDK settings and configuration delivery #12841
  4. Add dd-openfeature SDK exposure and flag evaluation pipelines #12842
  5. Add dd-openfeature SDK OpenFeature provider #12843
  6. Port master Feature Flags changes to the dd-openfeature SDK #12957
  7. Add the agent bridge for the dd-openfeature SDK #12975
  8. Connect the dd-openfeature SDK to the agent #12844
  9. Keep released dd-openfeature SDKs working with the agent #12976
  10. Resolve the Feature Flags settings like the SDK #12977
  11. Restore the agent Feature Flags behaviors through the bridge #12978
  12. Add agentless and standalone OpenFeature smoke tests #12846 👈 this PR

Jira ticket: APMLP-1512

🤖 Generated with Claude Code

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.91 s [-0.2%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.89 s 12.99 s [-1.4%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 17.10 s 17.02 s [-0.1%; +1.1%] (no difference)
startup:petclinic:iast:Agent 16.90 s 17.04 s [-1.5%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 16.71 s 16.80 s [-1.4%; +0.4%] (no difference)
startup:petclinic:sca:Agent 17.11 s 17.01 s [-0.3%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.19 s 16.11 s [-0.4%; +1.4%] (no difference)

Commit: 14744249 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T10:58:31.610214Z 0cc336d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-27T10:55:27.035196Z 0cc336d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cc336db05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dd-openfeature/README.md Resolved

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The standalone smoke suite fails before its application starts: its launcher omits the scope-diagnostics placeholder without supplying the required opt-out. Consequently, none of its evaluation scenarios can run.

Open Bits AI session

🤖 Bits Code Review · Commit 0cc336d

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Missing OpenTelemetry dependencies in the offline cache prevented targeted tests from reaching the OpenFeature scenarios, so runtime behavior remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 018613e

PerfectSlayer and others added 5 commits October 29, 2026 11:29
Extract the shared OpenFeature smoke test scenarios and run them against
the SDK alone, the SDK with the agent in agentless mode, and the SDK
with the agent through Remote Configuration. Document the new SDK
layout in ARCHITECTURE.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Describe the SDK setup, its configuration, the features by setup, the
migration from earlier versions and the design notes for contributors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The agent bridge ships with dd-java-agent 1.69.0, and the providers
released before 1.69.0 return the caller defaults with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Confidence is limited to static analysis of configuration, event delivery, and shutdown handling; the smoke tests were not executed.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 2e078e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants