Repository navigation
Add pull request size check - #12974
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 893558f10e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
The workflow executes PR-controlled shell code with OIDC access capable of obtaining repository-wide issue and pull-request write permissions. Its comment lookup can also target contributor comments instead of the bot’s warning.
🤖 Bits Code Review · Commit 893558f
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
dab7882 to
255b438
Compare
0ada71c
into
master
What Does This Do
This PR adds a pull request size check to prevent large change sets and difficult code reviews.
It promotes split and stacked PRs instead, which are a very nice way to with review.
Coding agents now how to deal with them so it should not be an issue for both humans and agent authors.
Motivation
When change set is too big, it becomes very hard for reviewers to verify the content.
Additionally, the automatic agentic review only raise 3 to 5 errors. So for a change of 3k LOC, it's about only one feedback per 600 to 1000 LOC. Limit to 1k LOC would also bring more automatic review comments (about 1 comment per 200 LOC at most).
Additional Notes
Line moves, deletions, test code and resources (
src/test), and version lock files do not count toward the change set size limit.Over the last 6 months, 28 of the 1235 PRs merged into
masterwould have been blocked.And there is an exceptional
tag: override pr size checklabel to unblock PR if needed.The check will run first as a non blocking workflow for evaluation.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]