Repository navigation
Prevent completed scope diagnostic commands from failing smoke tests - #13076
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The client waits for each response before sending another command, so consuming the command before responding preserves the protocol and prevents completed commands from being reread. The static reviewer found no actionable regressions.
🤖 Bits Code Review · Commit bc08a41
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
DDCI pipeline didn't start (sourcing_failed)... Please retry. DDCI Change Request: |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
453e9ea
into
master
What Does This Do
The scope diagnostics companion kept reopening an already handled command every 20 ms. In the CI job, a transient Cannot allocate memory error during one of those reads stopped its control thread and caused later tests to fail.
Consume each command before publishing its response, and retry a new command read up to five times on I/O failure.
Motivation
Additional Notes
Fixes errors like:
datadog.smoketest.SpringBootGrpcCompletableFutureTest > greeter 197 th time. Its stack trace, with the report directory shortened, was:Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]