Skip to content

Adds process tags to remote config payload#3658

Draft
dubloom wants to merge 7 commits intomasterfrom
dubloom/process-tags-rc
Draft

Adds process tags to remote config payload#3658
dubloom wants to merge 7 commits intomasterfrom
dubloom/process-tags-rc

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Feb 17, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tmp/build_extension/tests/ext/remote_config/process_tags.phpt (Test remote config request payload) from PHP.tmp.build_extension.tests.ext.remote_config (Datadog) (Fix with Cursor)
0002+ 
0004+ 
0001- entrypoint.basedir:remote_config
0002- entrypoint.name:process_tags
0003- entrypoint.type:script
0004- entrypoint.workdir:%s
0005- runtime.sapi:cli
0006+ 
0008+ 
0010+ 
...
tmp/build_extension/tests/ext/remote_config/process_tags.phpt (Test remote config request payload) from php.tmp.build_extension.tests.ext.remote_config (Datadog) (Fix with Cursor)
0002+ 
0004+ 
0001- entrypoint.basedir:remote_config
0002- entrypoint.name:process_tags
0003- entrypoint.type:script
0004- entrypoint.workdir:%s
0005- runtime.sapi:cli
0006+ 
0008+ 
0010+ 
...

🧪 1046 Tests failed

test anonymized auto user instrumentation() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772819634 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772819634 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772819599 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772819599 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm_data() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1772819619 gotten within 4999 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1772819619 gotten within 4999 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:181)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:233)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d000f07 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.32%. Comparing base (6bba842) to head (d000f07).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
+ Coverage   62.30%   62.32%   +0.01%     
==========================================
  Files         142      142              
  Lines       13586    13586              
  Branches     1775     1775              
==========================================
+ Hits         8465     8467       +2     
+ Misses       4314     4311       -3     
- Partials      807      808       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bba842...d000f07. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-06 19:02:26

Comparing candidate commit d000f07 in PR branch dubloom/process-tags-rc with baseline commit 6bba842 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-5.291µs; -3.349µs] or [-4.759%; -3.012%]

@dubloom dubloom force-pushed the dubloom/process-tags-rc branch from 57ca602 to d000f07 Compare March 6, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants