Optimize Symfony http.route caching with path map approach#3676
Open
cataphract wants to merge 2 commits intomasterfrom
Open
Optimize Symfony http.route caching with path map approach#3676cataphract wants to merge 2 commits intomasterfrom
cataphract wants to merge 2 commits intomasterfrom
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
cataphract
force-pushed
the
glopes/symfony-routes-redux
branch
from
3252e79 to
cab8ccb
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-03-05 16:48:03 Comparing candidate commit 9700e85 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 1 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:MessagePackSerializationBench/benchMessagePackSerialization
|
cataphract
force-pushed
the
glopes/symfony-routes-redux
branch
from
cab8ccb to
8ba7ce8
Compare
Replace per-route caching with a single cached map of all route paths.
This significantly improves performance and reduces memory usage.
Key improvements:
- Cache entire route map under single key '_datadog.symfony.route_paths'
- Store simple array: ['route_name' => '/path', ...]
- Smart invalidation based on compiled routes file mtime
- Cache indefinitely until Symfony recompiles routes or cache is
invalidated
- Gracefully disable if cache.app unavailable
Cache invalidation logic:
- Checks {cache_dir}/url_generating_routes.php modification time
- Compares against cached timestamp (created at cache build time)
- Rebuilds cache only when compiled routes file is newer
cataphract
force-pushed
the
glopes/symfony-routes-redux
branch
from
8ba7ce8 to
f8873ec
Compare
DD_TRACE_SYMFONY_HTTP_ROUTE=false incorrectly fully disabled Symfony request handling instrumentation. Properly scoped it to its original intent: the extraction of the Symfony route path for meta tag http.route.
cataphract
force-pushed
the
glopes/symfony-routes-redux
branch
from
f8873ec to
9700e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-route caching with a single cached map of all route paths. This significantly improves performance and reduces memory usage.
Key improvements:
Cache invalidation logic:
Description
Reviewer checklist