Skip to content

Fix debugger ephemerals handling#3685

Open
bwoebi wants to merge 1 commit intomasterfrom
bob/fix-debugger-crash
Open

Fix debugger ephemerals handling#3685
bwoebi wants to merge 1 commit intomasterfrom
bob/fix-debugger-crash

Conversation

@bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 3, 2026

This is now safe for nested debugger log probes as well not leaking into subsequent requests when probes are removed during runtime.

This is now safe for nested debugger log probes as well not leaking into subsequent requests when probes are removed during runtime.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from a team as a code owner March 3, 2026 17:23
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 3, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69a71b8800000000adcebafc5d819b6b
tid: 69a71b8800000000
hexProcessTraceId: adcebafc5d819b6b
hexProcessSpanId: ffee52a7b2b62582
processTraceId: 12524153206827228011
processSpanId: 18441768404340057474

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69a71c3400000000947078f0343ed17d
tid: 69a71c3400000000
hexProcessTraceId: 947078f0343ed17d
hexProcessSpanId: 93d7c6afbbb61a2e
processTraceId: 10696182088068944253
processSpanId: 10653201901639047726
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9c772a3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.08%. Comparing base (057d031) to head (9c772a3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3685      +/-   ##
==========================================
- Coverage   62.19%   62.08%   -0.11%     
==========================================
  Files         141      141              
  Lines       13352    13352              
  Branches     1746     1746              
==========================================
- Hits         8304     8290      -14     
- Misses       4256     4269      +13     
- Partials      792      793       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057d031...9c772a3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Mar 3, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-03 18:41:14

Comparing candidate commit 9c772a3 in PR branch bob/fix-debugger-crash with baseline commit 057d031 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+1.142µs; +2.258µs] or [+9.208%; +18.211%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-5.000µs; -3.900µs] or [-4.699%; -3.665%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-3.921µs; -2.339µs] or [-3.562%; -2.124%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants