Skip to content

test(profiling): ASAN test for #3898#3907

Draft
realFlowControl wants to merge 1 commit into
masterfrom
florian/test-3898
Draft

test(profiling): ASAN test for #3898#3907
realFlowControl wants to merge 1 commit into
masterfrom
florian/test-3898

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl commented May 22, 2026

Description

Adds a test for #3898 / #3896

This does not yet trigger in CI and that is because we do not run profiler tests against ZTS ASAN because the ZTS ASAN images we prebuild only have DEBUG ZTS ASAN and no NDEBUG version, but the profiler does not build against DEBUG PHP builds.

I hacked this a bit locally and not only does this newly added test fail, but also the other preloading test:

  Number of tests : 40
  Tests skipped   : 11
  Tests failed    : 2
  Tests passed    : 27

  Failed tests:

  [profiling] Profiling should only be enabled after preloading has happened
  [profiling] ASAN regression: ZTS preloading must not duplicate INI values from themselves

  ASAN caught the expected issue:

  ERROR: AddressSanitizer: heap-use-after-free
  READ of size 4
  #0 zend_string_dup .../Zend/zend_string.h:217
  #1 zai_config_ini_rinit .../zend_abstract_interface/config/config_ini.c:429
  ...
  freed by thread T0 here:
  #1 zend_string_release .../Zend/zend_string.h:339
  #2 zai_config_ini_rinit .../zend_abstract_interface/config/config_ini.c:428

@github-actions github-actions Bot added profiling Relates to the Continuous Profiler tracing labels May 22, 2026
@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 22, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.2]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). 1 failed test. Error: Assert that the default environment can be read from agent info in dd_trace_agent_env.phpt.

DataDog/apm-reliability/dd-trace-php | helper-rust integration coverage   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Failed to write archive entry contents due to ConnectionReset: reqwest::Error: source hyper::Error (Io connection reset).

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.4]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Failed to install live debugger span decoration probe. Error: command terminated with exit code 2.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.70% (-0.05%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2f8ce94 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 22, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-05-22 11:57:16

Comparing candidate commit 2f8ce94 in PR branch florian/test-3898 with baseline commit 0fb4c56 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant