Open
Conversation
This patch is related to 517326b, which aims to fix the compilation on musl.
glommer
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch is related to 517326b, which wraps
tidinto aSendWrapper, because on musl, tid carries a raw pointer, making the type !Send.I tried to build the current master on musl using rust 1.78, and what I see is that the wrapper gets destructed into its inner value before the move happens, causing the build to fail. I am not sure if this issue is related to rust version or if the original patch never worked.
I also removed the call to
enclose!. It was wastefully cloning 2 arcs that can be moved instead.Motivation
Fix the compilation on musl.
Related issues
517326b
Additional Notes
It would be nice to add musl into ci <3
Checklist
[] I have added unit tests to the code I am submitting
[] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture