Skip to content

feat(extension): support multi-extension GitHub release repos #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkirsteins wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(extension): support multi-extension GitHub release repos #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c9c2155
feat(extension): support shared release repositories
jkirsteins Jun 17, 2026
eed1fc4
fix(extension): clarify exact release tag installs
jkirsteins Jun 17, 2026
daac203
fix(extension): harden shared release installs
jkirsteins Jun 17, 2026
5ec36c8
fix(extension): make shared archive installs safer
jkirsteins Jun 17, 2026
1df678d
fix(extension): align remote listing with stable installs
jkirsteins Jun 17, 2026
9f9f5e1
fix(extension): bound remote extension archive scans
jkirsteins Jun 17, 2026
65de05a
fix(extension): cap decoded tar archive scans
jkirsteins Jun 17, 2026
d4efeb5
fix(extension): cap decoded tar reader
jkirsteins Jun 17, 2026
366b354
fix(extension): harden GitHub auth and rollback
jkirsteins Jun 17, 2026
ea0b8ec
fix(extension): unify staged extension writes
jkirsteins Jun 17, 2026
a8d0514
docs(wasm): document native-only extensions
jkirsteins Jun 18, 2026
b2aa789
Merge remote-tracking branch 'origin/main' into janis.kirsteins/multi…
jkirsteins Jun 18, 2026
8fc8f33
fix(ci): update test configs for jq field
jkirsteins Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ native = [
"dep:ssh-key",
"dep:futures",
"dep:tokio-util",
"dep:flate2",
"dep:tar",
"dep:zip",
Comment on lines +41 to +43

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Enable archive dependencies for WASI builds

The WASI CI/release job builds the CLI with cargo build --target wasm32-wasip2 --no-default-features --features wasi (.github/workflows/ci.yml:207), but these new archive crates are only enabled by the native feature while src/extensions/install.rs now references flate2, tar, and zip unconditionally. That leaves the WASI build without those optional dependencies and the binary will fail to compile; add them to the wasi feature or cfg-gate the archive install code out of that target.

Useful? React with 👍 / 👎.

@jkirsteins jkirsteins Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the WASI build locally with:

cargo check --target wasm32-wasip2 --no-default-features --features wasi

It passes because extensions are cfg-gated and not compiled for the WASI target.

Added a line in README.md under WASM limitations.

]
wasi = [
"dep:datadog-api-client",
Expand Down Expand Up @@ -126,6 +129,9 @@ russh = { version = "0.61", optional = true }
ssh-key = { version = "0.6", features = ["p256", "std"], optional = true }
futures = { version = "0.3", optional = true }
tokio-util = { version = "0.7", features = ["compat", "io"], optional = true }
flate2 = { version = "1", optional = true }
tar = { version = "0.4", optional = true }
zip = { version = "8", default-features = false, features = ["deflate"], optional = true }

# Datadog API client — pinned to 0.32.0 tag
# Use default-features = false; feature sets are activated per-target via features above
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ The `pup auth status` command works in WASM and reports which credentials are co

- No local token storage (keychain/file) — use `DD_ACCESS_TOKEN` or API keys
- No browser-based OAuth login flow
- Extensions are not included in WASM builds; `pup extension ...` and installed extension dispatch are native-only
- Networking relies on the host runtime's networking capabilities

### Running with Wasmtime
Expand Down
Loading