Skip to content

docs: remove stale multi-session guidance#600

Merged
platinummonkey merged 1 commit into
DataDog:mainfrom
srosenthal-dd:stephen.rosenthal/pup-docs-cleanup
Jun 18, 2026
Merged

docs: remove stale multi-session guidance#600
platinummonkey merged 1 commit into
DataDog:mainfrom
srosenthal-dd:stephen.rosenthal/pup-docs-cleanup

Conversation

@srosenthal-dd

Copy link
Copy Markdown
Member

Summary

PR #596 enforced a single-slot invariant for unnamed (default) sessions -- prune_other_default_sessions ensures a bare pup auth login always overwrites the existing default. The docs had two sections that still described the now-impossible case of multiple unnamed sessions coexisting.

Changes:

  • docs/OAUTH2.md (logout section): remove the DD_SITE=datadoghq.eu pup auth logout example and the note that pup auth logout doesn't accept --site
  • docs/OAUTH2.md (site selection): drop the "if you have multiple unnamed sessions on different sites, set DD_SITE to pick one" sentence
  • README.md (site selection): same sentence removed; replace with the accurate invariant ("it has no name to look up")

The first sentence of each site-selection paragraph -- about named sessions on multiple sites -- is still accurate and untouched.

PR DataDog#596 enforced a single-slot invariant for unnamed sessions --
`prune_other_default_sessions` ensures a bare `pup auth login` always
overwrites the existing default session. Two doc sites hadn't caught up:

- docs/OAUTH2.md logout section: remove the DD_SITE logout example and
  the note that `pup auth logout` doesn't accept `--site`
- docs/OAUTH2.md site selection: drop the "multiple unnamed sessions on
  different sites, set DD_SITE to pick one" sentence
- README.md site selection: same sentence removed
@srosenthal-dd srosenthal-dd marked this pull request as ready for review June 18, 2026 15:36
@srosenthal-dd srosenthal-dd requested a review from a team as a code owner June 18, 2026 15:36
@platinummonkey platinummonkey merged commit 88b0071 into DataDog:main Jun 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants