Skip to content

Fix downstream body analysis sample rate ENV name#6209

Merged
Strech merged 4 commits intomainfrom
appsec-60450-correct-appsec-rasp-scenario-sampling-env-name
Feb 11, 2026
Merged

Fix downstream body analysis sample rate ENV name#6209
Strech merged 4 commits intomainfrom
appsec-60450-correct-appsec-rasp-scenario-sampling-env-name

Conversation

@Strech
Copy link
Member

@Strech Strech commented Feb 4, 2026

Motivation

This is a discrepancy found between RFC API10 and system-tests

Changes

I've renamed early variant of the environment variable DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATE into DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE

I will check which libs are failing and add a bug ticket for them

Intake adjustments: https://github.com/DataDog/dd-go/pull/221351

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/python_lambda.yml                                             @DataDog/apm-python @DataDog/asm-python
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/appsec_rasp.py                                @DataDog/system-tests-core
utils/telemetry/intake/static/config_norm_rules.json                    @DataDog/apm-sdk

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 6 New flaky tests detected

tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM.test_log_method_snapshot[poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7f567122aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7f567122aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d760>.setup_failures

self = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d760>

    def test_log_method_snapshot(self):
>       self._assert()

...
tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM.test_span_decoration_method_snapshot[poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7f567122aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7f567122aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d940>.setup_failures

self = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d940>

    @missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
    def test_span_decoration_method_snapshot(self):
>       self._assert()
...
tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM.test_span_method_snapshot[poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7f567122aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7f567122aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d820>.setup_failures

self = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f566831d820>

    @missing_feature(context.library == "golang", reason="Not yet implemented", force_skip=True)
    def test_span_method_snapshot(self):
>       self._assert()
...
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f7e93a6 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from 6ffe742 to c06999f Compare February 5, 2026 17:25
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from c06999f to 8495c6b Compare February 6, 2026 12:50
@Strech Strech marked this pull request as ready for review February 6, 2026 12:53
@Strech Strech requested review from a team as code owners February 6, 2026 12:53
@Strech Strech requested review from claponcet, jandro996, taegyunkim, wconti27 and ygree and removed request for a team February 6, 2026 12:53
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from 8495c6b to 11229b6 Compare February 6, 2026 12:55
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch 2 times, most recently from e91775d to d6cd796 Compare February 10, 2026 08:44
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from d6cd796 to e172081 Compare February 10, 2026 10:52
@Strech Strech merged commit 24beb65 into main Feb 11, 2026
2618 of 2627 checks passed
@Strech Strech deleted the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch February 11, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants