[Golang] Activate API10 body analysis tests#6236
Conversation
The Go tracer now reads the correct env var name `DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE` (per the updated RFC), so the four tests previously marked as `bug (APPSEC-61152)` can be activated at `v2.7.0-dev`. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com> JJ-Change-Id: qryqpl
Strech
force-pushed
the
appsec-60450-correct-appsec-rasp-scenario-sampling-env-name
branch
3 times, most recently
from
d6cd796 to
e172081
Compare
…ody-tests JJ-Change-Id: pmrrrw
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b4712ed4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests/appsec/rasp/test_api10.py::Test_API10_redirect: v2.7.0-dev | ||
| tests/appsec/rasp/test_api10.py::Test_API10_redirect_status: v2.5.0-dev | ||
| tests/appsec/rasp/test_api10.py::Test_API10_request_body: bug (APPSEC-61152) | ||
| tests/appsec/rasp/test_api10.py::Test_API10_request_body: v2.7.0-dev |
There was a problem hiding this comment.
This change promotes the three API10 body-analysis tests tied to APPSEC-61152 to v2.7.0-dev, but leaves tests/appsec/rasp/test_api10.py::Test_API10_all on the same bug (APPSEC-61152) marker. Because Test_API10_all asserts both request/response body tags together, it remains skipped even after the bugfix this commit is enabling, which drops combined-path coverage and can hide regressions in the full API10 flow.
Useful? React with 👍 / 👎.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 4f12459 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f124591ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests/appsec/rasp/test_api10.py::Test_API10_redirect: v2.7.0-dev | ||
| tests/appsec/rasp/test_api10.py::Test_API10_redirect_status: v2.5.0-dev | ||
| tests/appsec/rasp/test_api10.py::Test_API10_request_body: bug (APPSEC-61152) | ||
| tests/appsec/rasp/test_api10.py::Test_API10_request_body: v2.7.0-dev |
There was a problem hiding this comment.
This change promotes the three APPSEC-61152 API10 body-related entries to v2.7.0-dev, but tests/appsec/rasp/test_api10.py::Test_API10_all is still marked bug (APPSEC-61152) in the same manifest section. Since Test_API10_all validates request and response body tags together, Go versions where the fix is present will still skip the combined-path assertion and can miss regressions in full API10 body analysis.
Useful? React with 👍 / 👎.
RomainMuller
deleted the
romain.marcadier/APPSEC-61152/activate-api10-body-tests
branch
2 participants
Summary
The Go tracer now reads the correct env var name
DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE(per theupdated RFC), so the four tests previously marked as
bug (APPSEC-61152)can be activated atv2.7.0-dev.Depends on: DataDog/dd-trace-go#4398
Co-Authored-By: Claude Opus 4 noreply@anthropic.com