Skip to content

Comments

New scenarios K8S_LIB_INJECTION_APPSEC#6237

Merged
avara1986 merged 12 commits intomainfrom
avara1986/APPSEC-61158
Feb 11, 2026
Merged

New scenarios K8S_LIB_INJECTION_APPSEC#6237
avara1986 merged 12 commits intomainfrom
avara1986/APPSEC-61158

Conversation

@avara1986
Copy link
Member

Implement new scenarios K8S_LIB_INJECTION_APPSEC_ENABLED and K8S_LIB_INJECTION_APPSEC_DISABLED

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

CODEOWNERS have been resolved as:

tests/k8s_lib_injection/test_k8s_lib_injection_appsec.py                @DataDog/system-tests-core
docs/scenarios/k8s_lib_injection.md                                     @DataDog/system-tests-core
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-core
tests/test_the_test/test_group_rules.py                                 @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/core.py                                       @DataDog/system-tests-core
utils/scripts/ci_orchestrators/k8s_ssi.json                             @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1e80dc9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@avara1986 avara1986 marked this pull request as ready for review February 9, 2026 12:00
@avara1986 avara1986 requested review from a team as code owners February 9, 2026 12:00
@avara1986 avara1986 requested review from claponcet, duncanista, jandro996 and mabdinur and removed request for a team February 9, 2026 12:00
@avara1986 avara1986 requested a review from amarziali February 9, 2026 12:00
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5e373a21e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +23 to +28
try:
weblog_response = requests.get(weblog_url, headers={"user-agent": "dd-test-scanner-log"}, timeout=10)
logger.info(f"Weblog response status: {weblog_response.status_code}")
except Exception as e:
logger.warning(f"Weblog request failed with exception: {e}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fail test when weblog/agent calls error

Swallowing request exceptions here means the disabled-by-default test can pass even when the weblog or test agent is unreachable: _check_appsec_traces logs the failure and eventually returns False, so test_appsec_disabled_by_default will accept a broken setup as “disabled.” This can mask real regressions in the cluster or tracing pipeline. Consider re-raising on request failures or asserting that the weblog/agent calls succeed (e.g., require at least one trace before concluding AppSec is disabled).

Useful? React with 👍 / 👎.

@avara1986 avara1986 merged commit 0382c54 into main Feb 11, 2026
2035 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-61158 branch February 11, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants