feat(php): Enable FFE tests and add /ffe endpoints#6243
Draft
leoromanovsky wants to merge 2 commits intomainfrom
Draft
feat(php): Enable FFE tests and add /ffe endpoints#6243leoromanovsky wants to merge 2 commits intomainfrom
leoromanovsky wants to merge 2 commits intomainfrom
Conversation
dc31279 to
f75549f
Compare
- Add /ffe/start and /ffe/evaluate to PHP parametric server - Add /ffe.php for end-to-end tests - Remove missing_feature for PHP FFE tests in manifest
f75549f to
2db71e0
Compare
Contributor
|
|
|
- Add Apache rewrite rule for /ffe endpoint to ffe.php - Mark Test_FFE_Exposure_Caching_Same_Subject as missing_feature because PHP shared-nothing architecture resets the in-memory ExposureCache on every HTTP request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable Feature Flagging and Experimentation (FFE) system tests for PHP, companion to DataDog/dd-trace-php#3630.
Changes
utils/build/docker/php/parametric/server.php: AddedPOST /ffe/startandPOST /ffe/evaluateendpoints to the PHP parametric test serverutils/build/docker/php/common/ffe.php: AddedPOST /ffeendpoint for end-to-end tests (Apache weblog)manifests/php.yml: Removedmissing_featurefortests/ffe/test_dynamic_evaluation.py,tests/ffe/test_exposures.py, andtests/parametric/test_ffe/test_dynamic_evaluation.pyDecisions
DDTrace\FeatureFlags\Providerfrom dd-trace-php for flag evaluation