Use a better API to handle agent trace polymorphism#6370
Merged
cbeauchesne merged 9 commits intomainfrom Feb 26, 2026
Merged
Conversation
Contributor
|
|
This comment has been minimized.
This comment has been minimized.
cbeauchesne
requested review from
mcculls and
paullegranddc
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a1a2fabc4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| link = span_links[0] | ||
| trace_id_high, trace_id_low = _get_span_link_trace_id(link, span_links_format) | ||
| trace_id_high, trace_id_low = _get_span_link_trace_id(link, span.trace.format) |
There was a problem hiding this comment.
When retrieve_span_links falls back to _dd.span_links, it converts links to legacy-style numeric fields (traceID/traceIDHigh as int), but this call now always passes span.trace.format into _get_span_link_trace_id. In runs where the trace is efficient format but span links are still emitted via _dd.span_links (the fallback branch in this same helper), _get_span_link_trace_id takes the efficient path and executes int(link["traceID"], 16), which fails because link["traceID"] is already an integer. This breaks the extract-behavior span-link assertions for mixed-format inputs.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present