Skip to content

fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
hannahkm/go-error-testing
Feb 25, 2026
Merged

fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
hannahkm/go-error-testing

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Feb 24, 2026

Motivation

Changes to error tracking in dd-trace-go v2.7.0 will cause system tests to break in the tracer. See this RFC.

Changes

  • For all other tracers AND dd-trace-go version v2.6.0, check that error.stack exists.
  • For dd-trace-go >= 2.7.0, check that error.handling_stack exists.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

CODEOWNERS have been resolved as:

manifests/cpp.yml                                                       @DataDog/dd-trace-cpp
manifests/cpp_httpd.yml                                                 @DataDog/dd-trace-cpp
manifests/cpp_nginx.yml                                                 @DataDog/dd-trace-cpp
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/envoy.yml                                                     @DataDog/system-tests-core
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/haproxy.yml                                                   @DataDog/system-tests-core
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/java_otel.yml                                                 @DataDog/system-tests-core
manifests/k8s_cluster_agent.yml                                         @DataDog/system-tests-core
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/nodejs_otel.yml                                               @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/python_lambda.yml                                             @DataDog/apm-python @DataDog/asm-python
manifests/python_otel.yml                                               @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
manifests/rust.yml                                                      @DataDog/apm-rust
tests/parametric/test_otel_span_methods.py                              @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@hannahkm hannahkm changed the title Hannahkm/go error testing fix: error tracking tags were incorrect for go tracer >= 2.7.0 Feb 24, 2026
@hannahkm hannahkm marked this pull request as ready for review February 24, 2026 15:02
@hannahkm hannahkm requested review from a team as code owners February 24, 2026 15:02
@hannahkm hannahkm requested review from BridgeAR and removed request for a team February 24, 2026 15:02
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f74864553a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hannahkm hannahkm requested a review from cbeauchesne February 25, 2026 14:22
For dd-trace-go >= v2.7.0, we set the throw stack (if available) in error.stack and the handling stack in error.handling_stack (always)
https://github.com/DataDog/dd-trace-go/pull/4322
"""
if context.library != "golang":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a line in all manifests (sorry), marking this as irrelevant?

Otherwise, all downstream processes will think that the test passes, which will be misleading.

@hannahkm hannahkm requested review from a team as code owners February 25, 2026 14:45
@hannahkm hannahkm requested review from a team as code owners February 25, 2026 14:45
@hannahkm hannahkm requested review from christophe-papazian, claponcet, jandro996, wantsui, xlamorlette-datadog and ygree and removed request for a team February 25, 2026 14:45
@hannahkm
Copy link
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 25, 2026

View all feedbacks in Devflow UI.

2026-02-25 15:17:45 UTC ℹ️ Start processing command /merge


2026-02-25 15:17:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 8m (p90).


2026-02-25 15:23:44 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants