fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372
fix: error tracking tags were incorrect for go tracer >= 2.7.0#6372gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f74864553a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| For dd-trace-go >= v2.7.0, we set the throw stack (if available) in error.stack and the handling stack in error.handling_stack (always) | ||
| https://github.com/DataDog/dd-trace-go/pull/4322 | ||
| """ | ||
| if context.library != "golang": |
There was a problem hiding this comment.
Could you add a line in all manifests (sorry), marking this as irrelevant?
Otherwise, all downstream processes will think that the test passes, which will be misleading.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
Changes to error tracking in dd-trace-go v2.7.0 will cause system tests to break in the tracer. See this RFC.
Changes
error.stackexists.error.handling_stackexists.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present