Enable PHP FFE parametric system tests#7003
Draft
leoromanovsky wants to merge 5 commits into
Draft
Conversation
Contributor
|
|
leoromanovsky
changed the title
|
…iners Mirrors the existing DD_AGENT_HOST / DD_TRACE_AGENT_URL injection so OTel-aware exporters in the system-under-test can reach the test agent's OTLP/HTTP listener without each tracer needing to special-case the parametric framework. Concretely: the PHP FFE OTLP-metrics path (DataDog/dd-trace-php#3911) resolves its endpoint per the OpenTelemetry spec — OTEL_EXPORTER_OTLP_METRICS_ENDPOINT, then OTEL_EXPORTER_OTLP_ENDPOINT, then localhost:4318. Without this injection, the parametric metric test had no way to reach the test agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PHP Milestone 1 now has a runtime-backed implementation in DataDog/dd-trace-php#3906. System-tests should validate that PHP can consume live
FFE_FLAGSRemote Config and evaluate through thelibdatadogevaluator before PHP moves on to exposures and metrics.Reference design doc: https://docs.google.com/document/d/1NvMfTpZWLBlFmEFNjdnlMyeVpy5l7KD8qujGFco6w2w/edit?tab=t.0
Changes
/ffe/startand/ffe/evaluateendpoints backed byDDTrace\FeatureFlags\Client.Test_Feature_Flag_Dynamic_EvaluationandTest_Parametric_FFE_Startinmanifests/php.yml.missing_featureuntil their separate milestones are implemented.tests/ffe/README.mdwith the validated PHP 8.2 parametric runbook and Bob's local artifact build command.Decisions
Verification
Using a local artifact built from DataDog/dd-trace-php#3906:
Local runs:
TEST_LIBRARY=php ./run.sh PARAMETRIC tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation -F tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation -vv: 25/25 passed.test-json-config-flag.json: 1/1 passed.test-case-of-7-empty-targeting-key.json: 1/1 passed.TEST_LIBRARY=php ./run.sh PARAMETRIC tests/parametric/test_parametric_endpoints.py::Test_Parametric_FFE_Start -F tests/parametric/test_parametric_endpoints.py::Test_Parametric_FFE_Start -vv: 1/1 passed.php -l utils/build/docker/php/parametric/server.php: passed../format.sh: passed.git diff --check: passed.