Skip to content

[docker_ssi] activate test_injection_metadata#7027

Open
annacai21 wants to merge 1 commit into
mainfrom
anna.cai/remove-missing-feature-injection-metadata
Open

[docker_ssi] activate test_injection_metadata#7027
annacai21 wants to merge 1 commit into
mainfrom
anna.cai/remove-missing-feature-injection-metadata

Conversation

@annacai21
Copy link
Copy Markdown
Contributor

@annacai21 annacai21 commented May 27, 2026

Motivation

The @missing_feature guard on test_injection_metadata was added while waiting for auto_inject#1075, which introduces the early "starting" injection-metadata event emitted by the injector. That change has since shipped, so the test now has the behavior it asserts against and the marker is no longer needed.

Changes

  • Remove the @missing_feature(reason="auto_inject#1075 adds early 'starting' injection-metadata event; not yet released") decorator from TestDockerSSIFeatures.test_injection_metadata in tests/docker_ssi/test_docker_ssi.py.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/docker_ssi/test_docker_ssi.py                                     @DataDog/injection-platform

@annacai21 annacai21 marked this pull request as ready for review May 27, 2026 15:31
@annacai21 annacai21 requested a review from a team as a code owner May 27, 2026 15:31
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd4733a47c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -164,7 +163,6 @@ def setup_injection_metadata(self):
self._setup_all()

@features.ssi_injection_metadata
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate activation on the injector version

This now runs the assertion for every datadog-apm-inject package, but the required early result == "starting" record is an injector feature, not a tracer feature. I checked the Docker SSI workflow path: utils/scripts/ci_orchestrators/gitlab_exporter.py forwards DD_INSTALLER_INJECTOR_VERSION as --ssi-injector-version, and utils/build/ssi/base/install_script_ssi.sh installs that exact datadog-apm-inject version, so auto-inject or release pipelines that exercise a version before auto_inject#1075 will hit this test and fail on the missing starting event instead of being marked missing-feature. Please keep this xfail conditional on context.dd_apm_inject_version or add the equivalent manifest coverage for older injector versions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant