[docker_ssi] activate test_injection_metadata#7027
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd4733a47c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -164,7 +163,6 @@ def setup_injection_metadata(self): | |||
| self._setup_all() | |||
|
|
|||
| @features.ssi_injection_metadata | |||
There was a problem hiding this comment.
Gate activation on the injector version
This now runs the assertion for every datadog-apm-inject package, but the required early result == "starting" record is an injector feature, not a tracer feature. I checked the Docker SSI workflow path: utils/scripts/ci_orchestrators/gitlab_exporter.py forwards DD_INSTALLER_INJECTOR_VERSION as --ssi-injector-version, and utils/build/ssi/base/install_script_ssi.sh installs that exact datadog-apm-inject version, so auto-inject or release pipelines that exercise a version before auto_inject#1075 will hit this test and fail on the missing starting event instead of being marked missing-feature. Please keep this xfail conditional on context.dd_apm_inject_version or add the equivalent manifest coverage for older injector versions.
Useful? React with 👍 / 👎.
Motivation
The
@missing_featureguard ontest_injection_metadatawas added while waiting for auto_inject#1075, which introduces the early"starting"injection-metadata event emitted by the injector. That change has since shipped, so the test now has the behavior it asserts against and the marker is no longer needed.Changes
@missing_feature(reason="auto_inject#1075 adds early 'starting' injection-metadata event; not yet released")decorator fromTestDockerSSIFeatures.test_injection_metadataintests/docker_ssi/test_docker_ssi.py.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present