fix: remove tests checking telemetry otlp configs which can be sensitive#7034
Draft
paullegranddc wants to merge 1 commit into
Draft
fix: remove tests checking telemetry otlp configs which can be sensitive#7034paullegranddc wants to merge 1 commit into
paullegranddc wants to merge 1 commit into
Conversation
Contributor
|
|
|
2750d0e to
10379d2
Compare
# Motivation We want to redact these values in libraries. These tests prevent these changes, but changing them outright will break libraries that haven't done the change
10379d2 to
b1f9db2
Compare
|
|
||
| @pytest.mark.parametrize( | ||
| ("library_env", "endpoint_env", "test_agent_otlp_http_port"), | ||
| ("library_env", "test_agent_otlp_http_port"), |
Contributor
There was a problem hiding this comment.
Please restore the endpoint_env pytest parameter and the value in the corresponding argument, that should allow the test cases to be wired up correctly and pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to redact these values in libraries. These tests prevent these changes, but changing them outright will break libraries that haven't done the change