Skip to content

Auto-activate rust easy wins for feature-flagging-and-experimentation-sdk #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd-octo-sts wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Auto-activate rust easy wins for feature-flagging-and-experimentation-sdk #7041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion manifests/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ manifest:
tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV1_ServiceTargets::test_not_match_service_target: missing_feature # Created by easy win activation script
tests/parametric/test_dynamic_configuration.py::TestDynamicConfigV2: missing_feature # Created by easy win activation script
tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py: '>=0.3.4-dev+c6880b8' # TODO: a lower version might be supported
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep pure utility span-enrichment tests skipped

With this file-level activation, Rust versions >=0.3.4-dev+c6880b8 now run every descendant not explicitly overridden; the added overrides skip all tracer-backed span-enrichment classes, leaving only Test_Span_Enrichment_Delta_Varint, which is a pure Python utility test with no test_library/Rust tracer interaction. That makes the Rust manifest report FFE span-enrichment coverage as passing without exercising the product behavior, so either keep the file skipped or add an explicit override for the delta-varint class until a tracer-backed class is enabled.

Useful? React with 👍 / 👎.

tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Child_Span_Propagation: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Default_Fallback: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Max_Experiments_Per_Subject: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Max_Serial_IDs: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Max_Subjects: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Serial_IDs: missing_feature
tests/parametric/test_ffe/test_span_enrichment.py::Test_Span_Enrichment_Subjects: missing_feature
tests/parametric/test_headers_b3.py: '>=0.2.1' # Modified by easy win activation script
tests/parametric/test_headers_b3.py::Test_Headers_B3::test_headers_b3_extract_valid: missing_feature # Created by easy win activation script
tests/parametric/test_headers_b3.py::Test_Headers_B3::test_headers_b3_inject_valid: missing_feature # Created by easy win activation script
Expand Down
Loading