Skip to content

Dev#105

Merged
jirhiker merged 17 commits into
pre-productionfrom
dev
Aug 26, 2025
Merged

Dev#105
jirhiker merged 17 commits into
pre-productionfrom
dev

Conversation

@jirhiker

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • I needed a way to deploy via github action without the need to have PR merges approved

How

Implementation summary - the following was changed / added / removed:

  • Created dev branch. added dev_deploy workflow

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

jirhiker and others added 17 commits August 25, 2025 17:13
@jirhiker jirhiker changed the base branch from main to pre-production August 26, 2025 01:09
@codecov-commenter

codecov-commenter commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
services/gcs_helper.py 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
db/thing.py 100.00% <100.00%> (ø)
schemas/thing.py 97.97% <100.00%> (+0.02%) ⬆️
services/gcs_helper.py 77.55% <33.33%> (-1.18%) ⬇️

@jacob-a-brown jacob-a-brown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do dev and pre-production deploy to the same service? Or is dev just for figuring out deployment, such as these {env}_deploy.yml scripts?

@jirhiker

Copy link
Copy Markdown
Member Author

Dev deploys to dev-ocotillo-api and pre-production deploys to ocotillo-api.
Questionable how useful this branch will be in the future. its main purpose is to test github actions without having to have merge requests approved.

@jirhiker jirhiker merged commit b101bcb into pre-production Aug 26, 2025
7 checks passed
@jirhiker jirhiker deleted the dev branch December 3, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants