Skip to content

fix: update contact model with alembic#35

Merged
jacob-a-brown merged 1 commit into
pre-productionfrom
jab-poc
Jul 23, 2025
Merged

fix: update contact model with alembic#35
jacob-a-brown merged 1 commit into
pre-productionfrom
jab-poc

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

No description provided.

@jacob-a-brown jacob-a-brown merged commit fa8e53b into pre-production Jul 23, 2025
3 checks passed
@jirhiker

Copy link
Copy Markdown
Member

Should we consider an automated process for running the alembic migrations on the production database?

@jacob-a-brown

Copy link
Copy Markdown
Contributor Author

That sounds like a good idea to me. Would tests be one-offs for a migration? That could also be a good way to track schema changes. The tests would have to be performed against databases with actual data to see if anything break or any errors are raised (production data in a testing environment? by using Docker images we could quickly spin up a database and then populate it with the existing production data and run tests/migrations).

I had some test data in my database and when I applied the migration it ran into an error, which elucidated this testing need to me (easily taken care of locally by deleting and remaking the database locally, but that won't always be the case because we won't want to spin down a production database).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants