Skip to content

jir-fix-thing-api #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 3 commits into from
Jul 25, 2025
Merged

jir-fix-thing-api #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
352062a
fixed thing api, tests. standardized to /thing/<thing_type>/<id>. e.g…
jirhiker Jul 23, 2025
4bfa53d
Merge branch 'pre-production' into jir-cleanup-thingapi
jirhiker Jul 25, 2025
2a64d20
fix: deprecated get thing by id
jirhiker Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions tests/test_thing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,16 @@ def test_add_thing_link():


# ===================== get ==========================
def test_get_thing_by_id():
response = client.get("/thing?thing_id=1")
assert response.status_code == 200
data = response.json()
assert "items" in data
items = data["items"]
assert len(items) == 1
assert items[0]["id"] == 1
assert items[0]["name"] == "Test Thing"
# def test_get_thing_by_id():
# # response = client.get("/thing?thing_id=1")
# response = client.get("/thing/base/1")
# assert response.status_code == 200
# data = response.json()
# # assert "items" in data
# # items = data["items"]
# # assert len(items) == 1
# assert data["id"] == 1
# assert data["name"] == "Test Thing"


def test_get_wells():
Expand Down
Loading