feat: enhance water well details with site name, historic depth notes, and field event participants#651
Merged
Merged
Conversation
…, and field event participants
Member
Author
Summary
API shape changes
Testing
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances the water well detail payload and well response with additional site/context fields, including site name, historic depth/access notes, location release status, and field event participants.
Changes:
- Add
site_name,historic_depth_to_water,well_location_note, and booleanopen_statusto well-related response schemas and corresponding DB model properties. - Include
field_event_participantsin the well details payload/schema and expand eager-loading for the latest field event sample. - Update and extend tests to cover new fields and behaviors (site name, boolean open status, participant list, note lists, location release status).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_well_inventory.py | Updates inventory assertions to reflect open_status boolean semantics. |
| tests/test_thing.py | Adds/updates API tests for site name, boolean open status, note lists, and field event participants. |
| services/well_details_helper.py | Adds eager-loading and returns field_event_participants in the details payload. |
| schemas/well_details.py | Extends well details response schema with field_event_participants. |
| schemas/thing.py | Adds site_name, note-derived fields, and changes open_status to boolean. |
| schemas/location.py | Adds release_status to LocationGeoJSONResponse. |
| schemas/field.py | Introduces FieldEventParticipantResponse. |
| db/thing.py | Adds site_name, note-derived properties, and boolean open_status derivation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1429804b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ategy for field event participants
ksmuczynski
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.