Skip to content

feat: enhance water well details with site name, historic depth notes, and field event participants#651

Merged
jirhiker merged 2 commits into
stagingfrom
bdms-720-723
Apr 15, 2026
Merged

feat: enhance water well details with site name, historic depth notes, and field event participants#651
jirhiker merged 2 commits into
stagingfrom
bdms-720-723

Conversation

@jirhiker

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 14, 2026 20:59

Copy link
Copy Markdown
Member Author

Summary

  • add site_name to well responses by deriving it from the ThingIdLink whose alternate_organization is NMBGMR
  • extend the well details payload with all Historical notes as historic_depth_to_water, all Access notes as well_location_note, top-level location release_status, and top-level field_event_participants
  • change open_status in well responses from the legacy string form to a boolean derived from the latest Open Status history value

API shape changes

  • well.site_name: string | null
  • well.historic_depth_to_water: string[]
  • well.well_location_note: string[]
  • well.current_location.release_status: ReleaseStatus
  • well.open_status: boolean | null
  • field_event_participants: FieldEventParticipantResponse[]

Testing

  • pytest tests/test_thing.py -k "open_status or site_name or well_details_payload"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enhances the water well detail payload and well response with additional site/context fields, including site name, historic depth/access notes, location release status, and field event participants.

Changes:

  • Add site_name, historic_depth_to_water, well_location_note, and boolean open_status to well-related response schemas and corresponding DB model properties.
  • Include field_event_participants in the well details payload/schema and expand eager-loading for the latest field event sample.
  • Update and extend tests to cover new fields and behaviors (site name, boolean open status, participant list, note lists, location release status).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_well_inventory.py Updates inventory assertions to reflect open_status boolean semantics.
tests/test_thing.py Adds/updates API tests for site name, boolean open status, note lists, and field event participants.
services/well_details_helper.py Adds eager-loading and returns field_event_participants in the details payload.
schemas/well_details.py Extends well details response schema with field_event_participants.
schemas/thing.py Adds site_name, note-derived fields, and changes open_status to boolean.
schemas/location.py Adds release_status to LocationGeoJSONResponse.
schemas/field.py Introduces FieldEventParticipantResponse.
db/thing.py Adds site_name, note-derived properties, and boolean open_status derivation.

Comment thread services/well_details_helper.py
Comment thread db/thing.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1429804b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/well_details_helper.py Outdated
@jirhiker jirhiker merged commit c3c7648 into staging Apr 15, 2026
8 checks passed
@jirhiker jirhiker deleted the bdms-720-723 branch April 15, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants