fix: pin joserfc in requirements.txt to unblock deploy#704
Merged
Conversation
authlib 1.6.x → 1.7.2 added joserfc as a new runtime dependency, but the lockfile bump did not regenerate requirements.txt, so joserfc was absent. The Google buildpack installs with pip --require-hashes, which rejected the unpinned `joserfc>=1.6.0` pulled transitively from authlib: ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: joserfc>=1.6.0 Add joserfc==1.7.1 with its sdist + py3-none-any wheel hashes from uv.lock. Verified joserfc is the only non-dev dependency in uv.lock missing from requirements.txt. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jirhiker
added a commit
that referenced
this pull request
Jun 8, 2026
…y) (#705) ### Why Deploy buildpack fails again — next unpinned transitive after the joserfc fix ([#704](#704)): ``` ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: python-discovery>=1.4 (from virtualenv==21.4.2->-r requirements.txt (line 2393)) ``` Root cause: `pre-commit` was listed in main `[project.dependencies]`, so it (and its whole toolchain — virtualenv, identify, nodeenv, cfgv, distlib, platformdirs) shipped to production. `virtualenv 21.x` introduced the unpinned transitive `python-discovery>=1.4`, which pip `--require-hashes` rejects. ### How - Move `pre-commit` from `[project.dependencies]` → `[dependency-groups] dev`. It's a dev-only tool, never imported by app code. - `uv lock` + `uv export --no-dev` regenerate the lock and requirements. - Result: pre-commit + entire chain (incl. virtualenv → python-discovery) removed from the production requirement set. ### Verification - Every non-dev package in `uv.lock` is still pinned + hashed in `requirements.txt`; only dev-group deps are absent. - Confirmed the linux `cp313` x86_64 wheels the buildpack installs are present (checked yarl). - `uv lock --check` passes. ### Notes - Large `requirements.txt` churn: besides removing the pre-commit chain, local `uv 0.9.7` emits only the py3.13-relevant wheel hashes (lock `requires-python >=3.13`) vs the old broader set. Functionally complete for the deploy target; CD regenerates with the same `uv export --no-dev` anyway. - `uv.lock` `revision` bumped 2 → 3 by uv; CD uses `setup-uv` latest (forward-compatible). - Unblocks the release build on [#695](#695) once merged to staging. --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
1.6.x → 1.7.2added joserfc as a new runtime dependency. The lockfile bump updateduv.lock/pyproject.tomlbutrequirements.txtwas not regenerated, so joserfc was missing. pip then resolved it transitively as the unpinnedjoserfc>=1.6.0, which--require-hashesrejects.How
joserfc==1.7.1with its sdist +py3-none-anywheel hashes copied fromuv.lock. Pure-python wheel → platform-independent, so both hashes are complete.uv.lockbut missing fromrequirements.txt(all other gaps are dev-group deps excluded by--no-dev).Notes
uv exportregen (local uv 0.9.7 emits a different per-platform hash set than CI, which would churn ~1000 lines).hotfix/v*branch.