BDMS 55: ensure location router is fully covered | remove expand functionality#79
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
requested changes
Aug 12, 2025
Return 204 Response from model_deleter
jirhiker
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
locationrouter was missing the following endpoints, which have now been implemented and tested/location/{location_id}/location/{location_id}has been simplified./location/{location_id}and PATCH/location/{location_id}were addedNotes
Any special considerations, workarounds, or follow-up work to note?
expandquery parameter is not used for/locationGET requests, so it was removed to simplify the code basetests/test_thing.pywere causing tests intests/test_location.pyto fail, so they were amended to improve test independence.model_deleterwas added toservices/crud_helper.pyto be reusable for all models.