Skip to content

HOT FIX: Staging deploy#93

Merged
jirhiker merged 2 commits into
pre-productionfrom
jir-asset-list-fix
Aug 21, 2025
Merged

HOT FIX: Staging deploy#93
jirhiker merged 2 commits into
pre-productionfrom
jir-asset-list-fix

Conversation

@jirhiker

@jirhiker jirhiker commented Aug 21, 2025

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • The staging deploy workflow was pushing to the nmsamplelocations service. The service has been renamed to ocotillo-api
  • transformer is calling get_storage_bucket for every asset

How

Implementation summary - the following was changed / added / removed:

  • Updated staging deploy workflow file
  • get bucket outside of list comprehension

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@jirhiker jirhiker changed the title HOT Fix: Staging deploy HOT FIX: Staging deploy Aug 21, 2025
@jirhiker jirhiker requested a review from jacob-a-brown August 21, 2025 15:29
@codecov-commenter

codecov-commenter commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/asset.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
api/asset.py 81.25% <0.00%> (ø)

@jirhiker jirhiker merged commit 20dd5de into pre-production Aug 21, 2025
3 checks passed
@jirhiker jirhiker deleted the jir-asset-list-fix branch August 29, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants