Skip to content

[BDMS-690 & BDMS-689]: Update the columns on the Wells list page to include contact info#242

Merged
TylerAdamMartinez merged 6 commits into
stagingfrom
TAM-BDMS-690
Apr 14, 2026
Merged

[BDMS-690 & BDMS-689]: Update the columns on the Wells list page to include contact info#242
TylerAdamMartinez merged 6 commits into
stagingfrom
TAM-BDMS-690

Conversation

@TylerAdamMartinez

@TylerAdamMartinez TylerAdamMartinez commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • The API did not include associated contacts for Things/Water Wells, even though relationships exist in the data model

How

Implementation summary - the following was changed/added/removed:

  • Added optional include_contacts query parameter to relevant endpoints (/thing and /thing/water-well)

Notes

Any special considerations

⚠️ DO NOT MERGE WITHOUT MERGING THE BACKEND CODE WITH IT. DataIntegrationGroup/OcotilloAPI#644

@TylerAdamMartinez TylerAdamMartinez self-assigned this Apr 10, 2026
@TylerAdamMartinez TylerAdamMartinez added the enhancement New feature or request label Apr 10, 2026
@TylerAdamMartinez TylerAdamMartinez changed the title [BDMS-690]: Update the columns on the Wells list page to include contact info **WIP** [BDMS-690]: Update the columns on the Wells list page to include contact info Apr 10, 2026
@TylerAdamMartinez

TylerAdamMartinez commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
Captura de pantalla 2026-04-10 a la(s) 12 23 35

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-690-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

TylerAdamMartinez
TylerAdamMartinez commented Apr 10, 2026
View reviewed changes
Comment thread src/pages/ocotillo/contact/list.tsx
id: thing.id,
},
}}
onClick={(e) => e.stopPropagation()}

@TylerAdamMartinez TylerAdamMartinez Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to stop the click from bubbling up to the row.

@jeremyzilar jeremyzilar Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good. There are also good patterns for making this also clickable or to have it surface the contact card inline, but that is something we can look at later

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-690-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

@TylerAdamMartinez TylerAdamMartinez mentioned this pull request Apr 10, 2026
Merged
@TylerAdamMartinez TylerAdamMartinez changed the title **WIP** [BDMS-690]: Update the columns on the Wells list page to include contact info [BDMS-690 & BDMS-689]: Update the columns on the Wells list page to include contact info Apr 10, 2026
@TylerAdamMartinez

TylerAdamMartinez commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author
Grabacion.de.pantalla.2026-04-10.a.la.s.13.17.41.mov

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-690-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-690-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

@jeremyzilar

jeremyzilar commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

I am excited to try this out with the new data coming in from the API

@TylerAdamMartinez

TylerAdamMartinez commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author
Grabacion.de.pantalla.2026-04-13.a.la.s.12.32.08.mov

Testing after the new api.

@TylerAdamMartinez

TylerAdamMartinez commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author
Grabacion.de.pantalla.2026-04-13.a.la.s.12.35.48.mov

Another test

@TylerAdamMartinez

TylerAdamMartinez commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@here, it feels slow, but I'm not sure if that's just the test environment. And I don't have an apples-to-apples comparison to production. 🤷‍♂️

jeremyzilar
jeremyzilar approved these changes Apr 13, 2026
View reviewed changes

@jeremyzilar jeremyzilar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It will be good to play with this. I am sure we'll want to adjust the order of the columns in a future PR

@TylerAdamMartinez TylerAdamMartinez merged commit 14b2d38 into staging Apr 14, 2026
3 of 4 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the TAM-BDMS-690 branch April 14, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyzilar jeremyzilar jeremyzilar approved these changes

@jirhiker jirhiker Awaiting requested review from jirhiker

@jacob-a-brown jacob-a-brown Awaiting requested review from jacob-a-brown

Assignees

@TylerAdamMartinez TylerAdamMartinez

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerAdamMartinez @jeremyzilar