Skip to content

BDMS-764: Add contact name & type to water well list search#274

Open
TylerAdamMartinez wants to merge 1 commit into
stagingfrom
TAM-BDMS-764
Open

BDMS-764: Add contact name & type to water well list search#274
TylerAdamMartinez wants to merge 1 commit into
stagingfrom
TAM-BDMS-764

Conversation

@TylerAdamMartinez

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • The Wells table search was limited to name_contains, restricting users to searching only by Name
  • Users could not search by other attributes such as contacts, type, or other indexed fields

How

Implementation summary - the following was changed/added/removed:

  • Replaced name_contains with query in the frontend request params

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Search results now depend on which fields are included in Thing.search_vector
  • DO NOT MERGE WITHOUT MERGING PR#667 FIRST

@github-actions

Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-764-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

@jeremyzilar jeremyzilar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦🌶️🍦🌶️🍦🌶️🍦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants