Skip to content

BDMS-864: fix map layer feature limits for water wells and locations layers #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksmuczynski wants to merge 1 commit into
base: staging
Choose a base branch
from
+8 −0
Open

BDMS-864: fix map layer feature limits for water wells and locations layers #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/hooks/useThingLayers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ const EMPTY_FEATURE_COLLECTION = {
features: [],
} as const

const HIGH_COUNT_LAYER_LIMITS = {
pageSize: 2000,
maxPages: 8,
maxFeatures: 15000,
}

export const useThingLayers = (
activeLayerKeys?: string[],
colorMappingByLayer: Record<string, boolean> = {}
Expand Down Expand Up @@ -283,6 +289,7 @@ export const useThingLayers = (
label: locations.label,
color: '#607d8b',
enabled: locations.exists && isLayerActive('ogc-locations'),
...HIGH_COUNT_LAYER_LIMITS,

@jirhiker jirhiker Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be simpler to increase the defaults in useOGCLayer.ts

OcotilloUI/src/hooks/useOGCLayer.ts

Line 27 in 4635809

pageSize = 1000,

@ksmuczynski ksmuczynski Jun 12, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jirhiker But wouldn't this apply to all layers, potentially slowing down the app?

})
const latestDepthToWaterLayer = useOGCLayer({
collection: latestDepthToWater.id,
Expand Down Expand Up @@ -349,6 +356,7 @@ export const useThingLayers = (
label: waterWells.label,
color: '#2b7dc0',
enabled: waterWells.exists && isLayerActive('ogc-water-wells'),
...HIGH_COUNT_LAYER_LIMITS,
})
const activelyMonitoredLayer = useOGCLayer({
collection: activelyMonitored.id,
Expand Down
Loading