fix: NULL Pointer Dereference in cJSON_GetErrorPtr When cJSON_Parse Receives NULL Input #1035 - #1066
Open
rishi-ragavan wants to merge 2 commits into
Open
fix: NULL Pointer Dereference in cJSON_GetErrorPtr When cJSON_Parse Receives NULL Input #1035#1066rishi-ragavan wants to merge 2 commits into
rishi-ragavan wants to merge 2 commits into
Conversation
setting global_error to NULL and returning. Fixes DaveGamble#1035 The function cJSON_ParseWithLengthOpts() didn't change global_error when returning NULL, so I added an else statement that made sure to set global_error to an empty string so it can later be dereferenced without an segementation fault error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1035
Overview
There was a possibility that cJSON_GetErrorPtr() could return a NULL pointer and later cause segmentation fault when dereferencing.
Fix
Whenever the global_error.json is NULL, instead of returning the global_error.json along with the global_error.position, I create a new safe_to_dereference empty string and return that.
Validation
Cleanly builds and passes all the tests.