Skip to content

feat: adding trackLink segment track to segment-plugin #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
enzoIto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: adding trackLink segment track to segment-plugin #319

enzoIto wants to merge 1 commit into from

Conversation

@enzoIto
Copy link

@enzoIto enzoIto commented Oct 4, 2022

Adding trackLink event to segment-plugin

@enzoIto enzoIto mentioned this pull request Oct 4, 2022
Open
@DavidWells
Copy link
Owner

DavidWells commented Nov 9, 2022

Looks good. One question tho, is trackLink an analytics v2 feature only?

This plugin is currently loading v1 of segment

analytics/packages/analytics-plugin-segment/src/browser.js

Line 79 in e94218a

const scriptMatch = customScriptSrc || 'cdn.segment.com/analytics.js/v1/'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enzoIto @DavidWells