Repository navigation
Remove redundant configuration and output test cases - #30
Closed
daveosterjr wants to merge 1 commit into
Closed
daveosterjr wants to merge 1 commit into
daveosterjr wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing during the October 13 board cleanup: everything in this pull request is already on the base branch, so merging it would change nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove eight redundant or implementation-only unit cases: mkdir call avoidance, a repeated encrypted-fallback scenario, mocked filesystem/property passthrough checks, and console-call counts without output-content assertions. Keep storage permissions, credential migration, fallback security, invalid-data handling and meaningful command/output checks. Exported production helpers stay unchanged.
This PR targets the existing staging branch and contains only the test hunks from #29. The affected tests and helper implementations match the pre-cleanup versions byte for byte at the staging base. No master runtime, dependency, package, policy or workflow changes are included. The user subsequently confirmed that the prior master delivery should remain and authorized automatic staging delivery. Use the existing Factory review and guarded staging merge workflow; do not apply the unused local master restoration.
Independent preservation review read the removed cases, retained suites and production helpers. Staging baseline passed 71 cases; final
npm run checkpassed typecheck, build, plugin checks, 63 tests and public-artifact validation. The staging baseline differs from master, so these are staging counts. All 12 master test files were inventoried and read; deletion decisions remain limited to these evidenced cases, not an exhaustive production-owner/history claim.No runtime behavior, public Command/API contract, package version, dependency, CI or release changes. No publication or live service smoke was run.