Fix critical auth and build failure regressions#106
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
/api/code-completionwas unauthenticated and queried globalrepo_files, allowing cross-tenant snippet leakage and unauthenticated AI usage.doneevents, leaving users with broken/incomplete repos while reporting success. GitHub repos were also created public by default.Root cause
Fix
user.idfor code completion and scope DB snippets throughrepositories.user_id.errorwithoutdone, and create GitHub repos private by default.Validation
pnpm exec eslint app/api/code-completion/route.ts 'app/api/projects/[id]/milestones/[milestoneId]/route.ts' lib/queries.ts app/api/build-app/route.ts && pnpm exec tsc --noEmitpassed (only known pre-existinglib/queries.tswarning).errorand nodone, with private GitHub repo creation.