Fix tenant scoping in code completion and milestones#99
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
/api/code-completionwas reachable without route-level auth and its DB fallback selected reusable snippets from allrepo_files, exposing other users' file paths/summaries throughselectedSnippetsand LLM context.Root cause
repositories.user_id, and API middleware only protects/dashboard/*.Fix
getCurrentUser()for code completion POST/PUT and scope fallback snippets to repositories owned by the authenticated user.Validation
pnpm exec tsc --noEmitpnpm exec eslint app/api/code-completion/route.ts app/api/projects/[id]/milestones/[milestoneId]/route.ts lib/queries.ts(passes with one pre-existing warning inlib/queries.ts)POST /api/code-completionandPATCH /api/projects/:id/milestones/:milestoneIdnow return401 Unauthorized.