fix: limit outgoing HTTP body reads before trimming#131
Merged
4 commits merged intoJun 26, 2026
Merged
Conversation
368b5f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
What was happening
DebugProbeHttpClientHandler was calling ReadAsStringAsync() on every outgoing request and response body — meaning the entire body was loaded into memory first, and only then trimmed down to MaxBodyCaptureSizeBytes.
For large payloads this creates unnecessary memory pressure proportional to the actual body size rather than the configured capture limit.
What I changed
Rewrote CaptureBodyAsync to read directly from the stream using a byte buffer, stopping as soon as MaxBodyCaptureSizeBytes is reached. No more full-body allocation.
Key decisions:
Test Results