Skip to content

chore(): add spotlees mvn plugin to pre-commit and format all files#61

Merged
brandPittCode merged 6 commits into
mainfrom
chore/add-mvn-spotless-plugin
May 29, 2026
Merged

chore(): add spotlees mvn plugin to pre-commit and format all files#61
brandPittCode merged 6 commits into
mainfrom
chore/add-mvn-spotless-plugin

Conversation

@brandPittCode
Copy link
Copy Markdown
Collaborator

PR Description

What this PR Provides

This pull request introduces Maven Wrapper support to the project, improves code formatting enforcement, and updates the build configuration for better consistency and automation. The main changes are grouped below.

Maven Wrapper Integration:

  • Added Maven Wrapper scripts (mvnw, mvnw.cmd) and configuration files (.mvn/wrapper/maven-wrapper.properties) to enable consistent Maven builds across different environments and simplify project setup. This also allows automatic downloading and validation of the Maven Wrapper JAR.
  • Added an Eclipse code formatter configuration (.spotless/eclipse-formatter.xml) to standardize Java code formatting.

Build and Formatting Automation:

  • Added a local pre-commit hook for Spotless code formatting checks on Java files, ensuring code style is enforced before commits. (.pre-commit-config.yaml)

Review

The reviewer must double-check these points:

  • The reviewer has tested the feature
  • The reviewer has reviewed the implementation of the feature
  • The documentation has been updated
  • The feature implementation respects the Technical Doc / ADR previously produced
  • The Pull Request title has a ! after the type/scope to identify the breaking
    change in the release note and ensure we will release a major version.

How to test

  • Run code tests

Breaking changes (if any)

  • N/A

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 28, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
30005138 Triggered Generic Password 58b8065 src/test/java/com/decathlon/idp_core/AbstractIntegrationTest.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread src/test/java/com/decathlon/idp_core/AbstractIntegrationTest.java Dismissed
@sonarqubecloud
Copy link
Copy Markdown

@brandPittCode brandPittCode merged commit 25766c1 into main May 29, 2026
16 checks passed
@brandPittCode brandPittCode deleted the chore/add-mvn-spotless-plugin branch May 29, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants