Skip to content

W3c rdf sparql conformance#7

Merged
GregHanson merged 36 commits into
mainfrom
w3c-rdf-sparql-conformance
May 6, 2026
Merged

W3c rdf sparql conformance#7
GregHanson merged 36 commits into
mainfrom
w3c-rdf-sparql-conformance

Conversation

@GregHanson
Copy link
Copy Markdown
Member

No description provided.

@GregHanson GregHanson requested a review from bharath181 March 5, 2026 16:19
@GregHanson
Copy link
Copy Markdown
Member Author

related HDT changes: DeciSym/hdt#1

Comment thread src/create.rs Outdated
Comment thread src/graph_iri.rs
/// - `canonical_path` exists and is canonicalized.
/// - `graph_iri` is syntactically valid.
#[derive(Debug, Clone)]
pub(crate) struct ResolvedGraphPath {
Copy link
Copy Markdown
Member Author

@GregHanson GregHanson Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, I have probably been overusing pub vs pub(crate) wrt best practices, as it makes it easier to reuse code in our downstream dependencies. May need to put a TODO on one of our boards to redefine any of the new code pub(crate)'s as we attempt to import these changes

Comment thread src/hdt_meta.rs
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done as a follow-up, but we should probably add metadata mutator for the file_iri that is generated and stored in the header. For instance:

<file:///tmp/.tmpxLjDTC/.tmpm9dGd8.nt> <http://purl.org/HDT/hdt#statisticalInformation> _:publicationInformation .

since this is generally a file that is either converted and/or combined from a series of sources, it's pointing to a random tempfile iri. Ideally we could set this to an IRI in the actual dataset as a means of potential query optimization or data linkage via metadata

Comment thread src/main.rs
entailment: query::EntailmentMode,
#[clap(long, default_value_t = false)]
/// Print query plan JSON to stderr for each query
debug_query_plan: bool,
Copy link
Copy Markdown
Member Author

@GregHanson GregHanson Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can map this to the top-level verbosity flag rather than tracking two levels of debug log messages

Comment thread src/rdf2nt.rs
Comment thread Cargo.toml Outdated
Comment thread src/query.rs Outdated
@GregHanson GregHanson merged commit f374121 into main May 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants