chore: pin .nvmrc to Node 24 - #92
Merged
Merged
Conversation
Amends #90, which moved the CI matrix, release workflow, and security workflow to Node 24 but left .nvmrc reading 20. Local `nvm use` therefore selected a runtime that cannot load node:sqlite and does not satisfy commander 15's engines.node >=22.12.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amends #90. That PR moved the CI matrix, release workflow, and security workflow to Node 24, but left
.nvmrcreading20— so localnvm usestill selected Node 20.Why it matters
Node 20 cannot satisfy either of the things
mainnow depends on:node:sqlitedoes not exist before Node 22.5 (require('node:sqlite')throwsERR_UNKNOWN_BUILTIN_MODULEon Node 18 and 20 — verified)commander15, merged in build(deps): bump commander from 14.0.3 to 15.0.0 (with jest ESM transform fix) #91, declaresengines.node >=22.12.0A contributor running
nvm usewould get a runtime the project no longer supports, with the mismatch surfacing as confusing native-module and module-resolution errors rather than a clear message.Changes Made
.nvmrc—20→24CHANGELOG.md—### Changedentry underUnreleasedTest Coverage
No tests — this file is not read by CI (workflows pin
node-versiondirectly) or by the build. It affects localnvm useonly.Backward Compatibility
✅ No runtime or build change —
⚠️ Contributors on Node 20 will switch to 24 on their next
.nvmrcis a developer convenience file.nvm use, and may neednpm rebuildfor native modules built against the old ABI.❌ Breaking changes: none.
Size: Small ✓
One-line file plus a changelog entry.