Update dependencies and enhance TLS support with AWS LC#47
Merged
Conversation
- Added new dependencies including `aws-lc-fips-sys`, `bindgen`, `cexpr`, `clang-sys`, `itertools`, `libloading`, `prettyplease`, `sha2`, and `typenum` in `Cargo.lock` and `Cargo.toml`. - Updated `rustls` configuration to utilize `aws-lc-rs` for TLS support, replacing `ring`. - Refactored `pulsing-actor` crate to integrate `aws-lc-rs` for TLS, ensuring compatibility with the updated dependencies. - Introduced ARM64 cross-compilation checks in CI workflow for enhanced build support.
- Added steps for setting up the build environment, caching Rust builds, checking code formatting, running Clippy for linting, building the project, and executing tests. - Removed redundant steps to streamline the CI process, ensuring efficient and effective builds across multiple platforms.
- Corrected the formatting in `.cargo/config.toml` by ensuring a newline at the end of the file. - Updated `rustflags` to maintain consistency in the configuration for ARM builds.
- Introduced a new lint job for Rust and Python, including formatting checks and linting with Clippy and Ruff. - Streamlined Rust test jobs to focus on building and testing, removing redundant formatting checks. - Updated Python test jobs to include coverage collection and improved naming for clarity. - Added steps for uploading coverage reports to Codecov, ensuring better visibility of test coverage. - Refactored job names and comments for improved readability and organization in the CI configuration.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 45 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Updated CI configuration for improved clarity and organization, including renaming jobs and refining comments. - Streamlined Rust ARM64 cross-compilation checks, focusing on building without testing. - Enhanced Python build jobs to support multi-platform testing and added a new job for building Linux ARM64 wheels. - Simplified steps for installing ARM64 targets and tools, ensuring a more efficient setup process. - Adjusted job names for better readability and consistency across the CI pipeline.
- Removed unused dependencies from `Cargo.lock` and `Cargo.toml`, including `aws-lc-fips-sys`, `bindgen`, `cexpr`, `clang-sys`, `itertools`, `libloading`, and `prettyplease`. - Updated `aws-lc-rs` configuration in `Cargo.toml` to remove the `bindgen` feature. - Streamlined CI workflow by removing ARM64 cross-compilation checks and enhancing Python build and test jobs for better clarity and organization.
- Introduced separate jobs for building wheels on macOS and Linux, improving clarity and organization. - Updated Python version for macOS builds to 3.10 and refined caching strategies for Rust builds. - Enhanced testing jobs for macOS and Linux, including multi-version and multi-architecture support. - Added a new job for testing on Fedora, ensuring comprehensive coverage across platforms. - Improved artifact naming conventions for better identification of build outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-lc-fips-sys,bindgen,cexpr,clang-sys,itertools,libloading,prettyplease,sha2, andtypenuminCargo.lockandCargo.toml.rustlsconfiguration to utilizeaws-lc-rsfor TLS support, replacingring.pulsing-actorcrate to integrateaws-lc-rsfor TLS, ensuring compatibility with the updated dependencies.Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)