feat(dipu): implement setter/getter for offset&seed of diopiGenerator#762
Open
Bonbon-Tang wants to merge 9 commits intoDeepLink-org:mainfrom
Open
feat(dipu): implement setter/getter for offset&seed of diopiGenerator#762Bonbon-Tang wants to merge 9 commits intoDeepLink-org:mainfrom
Bonbon-Tang wants to merge 9 commits intoDeepLink-org:mainfrom
Conversation
Bonbon-Tang
requested review from
fandaoyi,
lljbash and
mrdanielw
as code owners
lljbash
reviewed
Apr 1, 2024
Member
lljbash
left a comment
lljbash
left a comment
There was a problem hiding this comment.
建议 description 里面关联一下 diopi 的更新，如有必要，还得更新 diopi
Comment on lines
190
to
193
| { | ||
| offset = gen_impl->get_offset(); | ||
| seed = gen_impl->current_seed(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
DIOPI那边需要拿到这两个参数
Collaborator
Author
There was a problem hiding this comment.
这个我研究下，之前应该写了线程锁
lljbash
changed the title
lljbash
changed the title
lljbash
approved these changes
Apr 10, 2024
xuq7410
pushed a commit
to xuq7410/deeplink.framework
that referenced
this pull request
May 23, 2024
* delete python relate depandcy * optimize the location of releasing python GIL lock * add Python.h dir to include path * rename gil_scoped_release to GilScopedRelease --------- Co-authored-by: zhaoguochun1995 <zhaoguochun1995@sensetime.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加 offset和seed获取
DeepLink-org/DIOPI#1127