Skip to content

fix: White screen after deleting a tag #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katsyuta wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: White screen after deleting a tag #340

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f443212
fix: rebuild tree before render component where tree use
katsyuta Jul 5, 2026
f64a812
chore: remove console log
katsyuta Jul 5, 2026
d3028fc
Merge branch 'master' into 339-bug-white-screen-after-deleting-a-tag
katsyuta Jul 6, 2026
e95e483
Merge branch 'master' into 339-bug-white-screen-after-deleting-a-tag
katsyuta Jul 6, 2026
2d18f8e
refactor: use hook to update tree
katsyuta Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions packages/app/src/features/MainScreen/TagsPanel/TagsTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { createContext, FC, useEffect, useMemo, useRef } from 'react';
import React, { createContext, FC, useMemo, useRef } from 'react';
import {
buildProxiedInstance,
FeatureImplementation,
Expand Down Expand Up @@ -64,6 +64,22 @@ export type ITagsListProps = {
contextMenu: TagContextMenuCallbacks;
};

/**
* Rebuild the tree while rendering, before rendering child components,
* otherwise they may use a stale tree that is out of sync with the latest tags list
*/
const useRebuildTreeOnTagsChange = (
tree: { rebuildTree: () => void },
tags: Record<string, TagNode>,
) => {
const prevTagsRef = useRef(tags);
if (prevTagsRef.current !== tags) {
prevTagsRef.current = tags;

tree.rebuildTree();
}
};

export const TagsTree: FC<ITagsListProps> = ({
tags,
activeTag,
Expand Down Expand Up @@ -118,9 +134,7 @@ export const TagsTree: FC<ITagsListProps> = ({
});

// Rebuild tree by changes
useEffect(() => {
tree.rebuildTree();
}, [tags, tree]);
useRebuildTreeOnTagsChange(tree, tags);

return (
<TagsListContext value={context}>
Expand Down