Add dirty-spine gas regression coverage - #31
Merged
Merged
Conversation
dangerousfood
marked this pull request as ready for review
August 14, 2026 17:14
dangerousfood
force-pushed
the
codex/dirty-spine-gas-regressions
branch
from
August 14, 2026 17:27
2cf8a9c to
025e335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The incident trace showed a shallow dirty right spine being materialized before insertion. The isolated benchmark measures the observed rest at 528,120 gas, while its match and cancel remain below 100k. At depth 64, match and cancel remain near the expected ~400k ceiling, but dirty-spine rest reaches 3,931,430 gas. This distinguishes the deferred materialization problem from normal matching cost and gives a concrete baseline for the contract fix.
Incident transactions:
0xe4702419f4de3df0f31e4ce7b5dffcbfda2590b69c717abb6924be8dc0400a680x1c3f782b619200f689a7f890f4777a446dd92bf97fd59823d7611c58aad45ce2Validation
make test: 390 passedforge fmt --checkforge lintgit diff --check