fix(api): fail OpenAI oracle provider errors - #127
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
ai-oraclecould report a successful paid response with an empty analysis when the OpenAI fallback returned a non-2xx error body or an empty response. That logs the call as success and charges credits instead of surfacing the upstream failure.Root cause
The OpenAI provider branch parsed
resp.json()and immediately returnedtextfromchoices[0]without checkingresp.okor requiring non-empty output.Fix
ai-oracleprovider branch.oracle_failed502 path.Validation
cd api && npm run build && node tests/tools-credits-hardening.test.mjs