fix(api): preserve monthly free credit refreshes - #128
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Free-tier agents below the monthly credit floor could be silently skipped by the monthly refresh job if any unrelated account update happened after the month started. Authenticated API calls update
Agent.lastSeenAt, which also advances Prisma'supdatedAt, so a delayed or retried monthly job could treat active users as already refreshed and withhold their free credits.Root cause
refreshMonthlyCreditsusedAgent.updatedAt >= startOfMonthas its idempotency guard even thoughupdatedAtis a broad account mutation timestamp, not a refresh marker.Fix
Use an explicit
AuditLogmarker (monthly_free_credit_refresh) for per-month idempotency. The job now records both granted and skipped high-balance accounts, keeps the existing top-up-only guard so purchased balances are never lowered, and sends refresh email copy using the actual credits added.Validation
npm run buildnode tests/tools-credits-hardening.test.mjsnode tests/critical-regressions.test.mjs