fix(api): release video quota on failed Runway starts - #129
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
video-generatereserved a per-identity hourly quota slot before Runway had accepted a generation task. If Runway returned a pre-task failure (for example configured model unavailable, non-2xx start error, or a 2xx response without a task id), the route returned an error without releasing the slot. Five such failures could exhaust the caller's hourly video quota even though no generation was started, blocking successful retries until the UTC hour reset.Root cause
The route only released the slot for daily-limit and insufficient-credit failures. The Runway start path had no distinction between failures before a task existed and failures after a real task id existed.
Fix
Track whether a Runway task id has been created, and release the hourly slot on pre-task start failures only. Poll failures after a task id exists still count against the cap because Runway may have consumed vendor capacity.
Validation
cd api && npm run build && node tests/hardening-caps-audit.test.mjsprisma generate && tscsuccessfully.releaseVideoHourlySlotand the video route's no-task-created release branches.