endpoint: optimize __eq__ via product_id#14806
Open
valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
Open
endpoint: optimize __eq__ via product_id#14806valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
valentijnscholten wants to merge 1 commit intoDefectDojo:bugfixfrom
Conversation
Maffooch
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Endpointequality method compares the fullself.productfields. This can trigger a query to get the product details and sometimes results in a 1+N query pattern, for example during previewing of deletes.This PR switches to comparing
self.product_id.The equivalent Location models don't have an equality method.