This repository was archived by the owner on Jan 20, 2024. It is now read-only.
Load application configuration from file#159
Open
tsmolka wants to merge 1 commit intoDefensePointSecurity:masterfrom
Open
Load application configuration from file#159tsmolka wants to merge 1 commit intoDefensePointSecurity:masterfrom
tsmolka wants to merge 1 commit intoDefensePointSecurity:masterfrom
Conversation
Contributor
|
So that goes pretty aggressively against the 12 Factor App idea of keeping configuration out of code. |
Contributor
|
Just to chime into this, with respect to the 12 Factor App rules, I use configparser and usually make a config.ini( or something there of) that works really well imo. As long as .gitignore has that file in it, you should be good to go. TBH, I hate having to remove and re-add my API keys to the file I'm pushing/pulling each time. To note, I'm not even close to being a developer, but as someone who does numerous pushes and pulls, I like the notion. Just my 1 cent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, what about moving settings to an external file? It's a good practice and simplifies configuration. Other settings (e.g. db file) should ideally be moved there as well.