Open
Conversation
nitsky
force-pushed
the
import-attributes-in-resolver
branch
from
5a6350e to
10343ab
Compare
nitsky
force-pushed
the
import-attributes-in-resolver
branch
from
10343ab to
3a86441
Compare
Collaborator
|
@nitsky some test errors, can you fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I recently added support to quickjs for the normalize func to access import attributes quickjs-ng/quickjs#1349. This PR adds the import attributes to the Resolver trait accordingly. I regenerated the bindings in this PR in order to use the updated API from quickjs, not sure if you want that in a separate PR though.
Checklist